Skip to Content.
Sympa Menu

freetds - Re: [freetds] always poll, even without poll(2)

freetds AT lists.ibiblio.org

Subject: FreeTDS Development Group

List archive

Chronological Thread  
  • From: "James K. Lowden" <jklowden AT freetds.org>
  • To: FreeTDS Development Group <freetds AT lists.ibiblio.org>
  • Subject: Re: [freetds] always poll, even without poll(2)
  • Date: Tue, 30 Dec 2008 01:34:57 -0500

Frediano Ziglio wrote:
> What do you think about
...
> +#if defined(WIN32)
> + /* Win32 cares about the number of descriptors, not the
> highest one. */ + ++maxfd;
> +#else
> if (p->fd > maxfd)
> maxfd = p->fd;
> +#endif

It's a very close call. Your way is slightly more efficient (probably)
and mine relies a little less on the preprocessor. But yours might be a
little clearer, finally, because maxfd isn't calculated one way first and
later overridden. Feel free to change it if you like.

Regards,

--jkl




Archive powered by MHonArc 2.6.24.

Top of Page