[SM-Commit] GIT changes to master grimoire by Ismael Luceno (1dae39b079e11622e568e6f47c0bc8b30b2bf277)

Eric Sandall eric at sandall.us
Wed Nov 9 20:38:10 EST 2011


On Sep 17, 2011, at 12:24 AM, Bor Kraljič wrote:

> On 17. of Sep 2011 3:29:12 Ismael Luceno <ismael.luceno at gmail.com> wrote:
>> El Thu, 15 Sep 2011 10:34:02 +0200
>> Bor Kraljič <pyrobor at ver.si> escribió:
>> <...>
>> 
>>>> a/utils/flashrom/DETAIL b/utils/flashrom/DETAILS
>>>> index 916ea2d..7868d42 100755
>>>> --- a/utils/flashrom/DETAILS
>>>> +++ b/utils/flashrom/DETAILS
>>>> @@ -1,7 +1,12 @@
>>>> 
>>>>            SPELL=flashrom
>>>> 
>>>> -if [[ ${FLASHROM_SCM} == "y" ]]
>>>> +if [[ ${FLASHROM_BRANCH} == scm ]]
>>>> 
>>>> then
>>>> 
>>>> +  if [[ $FLASHROM_AUTOUPDATE = y ]]
>>>> +  then
>>>> +         VERSION=$(date +%Y%m%d)
>>>> +  else
>>>> 
>>>>          VERSION=scm
>>>> 
>>>> +  fi
>>>> 
>>>>           SOURCE=${SPELL}-${VERSION}.tar.bz2
>>>> 
>>>>    SOURCE_URL[0]=svn://coreboot.org/flashrom/trunk:${SOURCE%.ta
>>>>    r.bz2}
>>>> 
>>>>   FORCE_DOWNLOAD=on
>>> 
>>> That is not good. SOURCE for scm AUTOUPDATE shouldn't be
>>> ${SPELL}-${VERSION}.tar.bz2.  Because that it will re-download
>>> *everything* from upstream on each update.
>>> 
>>> We should use SOURCE=${SPELL}-scm.tar.bz2 for VERSION=$(date +%Y%m%d)
>>> just like for VERSION=scm. That way only new changes are pulled down.
>>> 
>>> Spell flashrom is just an example I noticed that you updated other
>>> spells that way too.
>>> 
>>> Regards, Bor
>> 
>> Yep, fixed now. Sorry, missed that one.
>> 
>> Thanks!
> I mentioned that flashrom is just an example there are other spells with such 
> source. Spell *irssi* has the same problem. Others that you updated are OK I 
> think.

Also, you should use VERSION=svn (or just use -svn in SOURCE instead of $VERSION) so if/when they switch to a new SCM you don't have an incompatible tarball.

-sandalle

Eric Sandall                     |  Source Mage GNU/Linux Developer
eric at sandall.us PGP: 0xA8EFDD61  |  http://www.sourcemage.org/
http://eric.sandall.us/          |  http://counter.li.org/  #196285



More information about the SM-Commit mailing list