[freetds] freebcp patch for charset

jklowden at schemamania.org jklowden at schemamania.org
Mon Jul 20 09:31:29 EDT 2009


On Mon, Jul 20, 2009 at 11:43:03AM +0200, Frediano Ziglio wrote:
> Does this patch seems resonable ??

Yes! 

Sybase bcp uses -J, but I think -C might be better.  I don't know what "J" would stand for, and your -C works slightly differently.  

http://manuals.sybase.com/onlinebooks/group-as/asg1250e/util/@Generic__BookTextView/10086;pt=10086

We need to decide how to handle Sybase servers.  TDS 5.0 login packets include the client character set.  I think the user should say "-C ISO-8859-1" and we should map that to "iso_1".  That way the user provides the same charset name regardless of server type, even though in the TDS 5.0 case it's the server, not libiconv, that performs the conversion.  

(Last I checked, we were sending the GNU name for the character set by mistake, not Sybase's name.  I don't see a fix for it in ChangeLog.)  

> I don't know if proprietary library has an option for this

dbcharsetconv, dbservcharset, dbgetcharset, DBSETLCHARSET.  Or did you mean something else?  

I see some of these are missing from api_status.doc.  I'll fix that.  

Regards, 

--jkl


More information about the FreeTDS mailing list