Subject: Re: [SM-Commit] GIT changes to master grimoire by Vlad Glagolev (e56a7d51157cbf2dde47515a5abd8cf17a5d2313)
Date: Wed, 22 Apr 2015 12:07:21 +0300
On Wed, 22 Apr 2015 09:12:14 +0200
Thomas Orgis <thomas-forum AT orgis.org> wrote:
> Am Wed, 22 Apr 2015 01:42:29 -0500
> schrieb Vlad Glagolev <scm AT sourcemage.org>:
>
> > +2015-04-22 Vlad Glagolev <stealth AT sourcemage.org>
> > + * FUNCTIONS: fixed check_tmp_noexec for tmp-less systems
> > +
>
> Thanks for reacting to my nightly tantrum. I got one suggestion, though:
>
> The final remount enforces noexec
>
> mount -o noexec,remount $1 &&
>
> Why don't we just do a
>
> mount -o remount $1 &&
>
> ? As one might have /tmp without noexec in fstab. This function will
> override that.
we can't simply remount, because that will keep 'exec' option.
we must check for noexec option for /tmp in current /etc/fstab.
fixed in test with (f5aaec3), cherry-picked into stable-0.62 with
(58d901f) and backported to z-rejected with (c6c5859).