Subject: Re: [SM-Commit] GIT changes to master grimoire by Bor Kraljič (d7a8fe66abf6bd38d69d19707580fcbf6d849e45)
Date: Mon, 28 Sep 2009 11:25:58 -0700
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Jaka Kranjc wrote:
> On Monday 28 of September 2009 11:30:21 Bor Kraljič wrote:
>> --- /dev/null
>> +++ b/audio-libs/liblastfm/BUILD
>> @@ -0,0 +1,4 @@
>> +QTDIR=/usr &&
>> +PATH=$QTDIR/bin/qt4:$PATH &&
>> +./configure --prefix /usr &&
>> +default_build_make
> Is the configure special - why don't you just use default_build? Hardcoding
> QTDIR is bad, we have a profile script for that. Also check FUNCTIONS.
You should source /etc/profile.d/kde4.sh to get the KDE4 variables, not
hardcode them.