Subject: Re: [SM-Commit] GIT changes to master z-rejected grimoire by George Sherwood (e8e851c9f4255c6f54037dd045154a6c387f02e6)
Date: Wed, 10 Sep 2008 22:27:10 +0200
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Eric Sandall wrote :
> On Wed, 10 Sep 2008 18:55:54 +0200
> Julien ROZO <julien AT rozo.org> wrote:
> <snip>
>> Thanks George for pointing out this problem. I checked more accurately
>> the x86 package, and the openoffice.org3.0-*-menus-3.0-*.noarch.rpm
>> exists in two versions, including an obsolete one : 9350 is the latest
>> build, while 9347 is the oldest and does not exist in x86_64 package.
>>
>>> I tried multiples time and always had the same error from PRE_BUILD.
>>> Understand this is not generic enough, but it needs to work.
>> I suggest we add in DETAILS a variable to handle the last digits,
>> something like :
>>
>> BUILD_VERSION=9350
>>
>>
>> What do you, and other mages, think of it ?
>> It is heavier than nothing to update at each version bump, but at
>> least it's declared near VERSION so one will (I hope !) think of
>> update it while updating the spell.
>> Moreover it can more or less handle upstream packaging problem.
>> And it seems cleaner to me than having to change it in another script
>> than DETAILS.
>
> Why not just grab the last file listed and assume it's the correct one?
> e.g. `ls openoffice.org3.0-freedesktop-menus-3.0*|tail -n1`.
>
Yes, I thought of this trick too. Then I wonder what will happen if, in
the ooo package, there are desktop-integration RPMs for a yet-to-release
build ? ie. the opposite of our case, where files from old build still
sit => tail would then be head, and even if the trick keeps on working,
wrong version of desktop files will be installed.
I admit it's only a supposition, it's likely not to happen, but I don't
trust the content of ooo packages anymore ;)
I can do the ls trick, or declare a BUILD_VERSION in DETAILS. Any other
suggestion please ? I'm open minded :)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org