Subject: Re: [SM-Commit] GIT changes to master grimoire by Vlad Glagolev (6c66d985ef9c04e0f47c41f245328ff1b80a854a)
Date: Mon, 07 Jan 2008 14:36:49 +0100
Apart from the obvious that was already shou^Wsaid on irc, here are some
other
notes/bugs (yes, I read the whole crappy commit diff).
First a general note. You don't comment your actions very well. Take
libxml-perl for example, you modified/removed a bunch of files, but only
mentioned BUILD and DETAILS in the history. "Cleanup" is very general and
fits your space and bracket squishing, however I think that things like
changing the SOURCE_URL, adding a long description or license should all be
mentioned separately. Similar could be said for the verbosity of "useless$".
Even with potent tools such as git log and git blame, HISTORY is still a
valuable source of information, especially for the curious user.
On Monday 07 of January 2008 07:47:33 Vlad Glagolev wrote:
> GIT changes to master grimoire by Vlad Glagolev <stealth AT sourcemage.org>:
> diff --git a/perl-cpan/dailystrips/BUILD b/perl-cpan/dailystrips/BUILD
> index 960052a..bb0cbee 100755
> --- a/perl-cpan/dailystrips/BUILD
> +++ b/perl-cpan/dailystrips/BUILD
> @@ -1,5 +1 @@
> -(
> -
> - perl install.pl
> -
> -) > $C_FIFO 2>&1
> +perl install.pl
> diff --git a/perl-cpan/dailystrips/HISTORY b/perl-cpan/dailystrips/HISTORY
> index c44ffdd..64355d4 100644
> --- a/perl-cpan/dailystrips/HISTORY
> +++ b/perl-cpan/dailystrips/HISTORY
> @@ -1,3 +1,6 @@
> +2008-01-07 Vlad Glagolev <stealth AT sourcemage.org>
> + * BUILD: cleaned up
> +
> 2006-09-21 Juuso Alasuutari <iuso AT sourcemage.org>
> * DETAILS: [automated] Removed MAINTAINER.
>
This is a build api1 spell. You didn't change that, but adapted BUILD to be
more api2-like anyway. I'm not sure logging works now.
Can this spell not be changed to api2? Otherwise this should be reverted.
> diff --git a/perl-cpan/digest-md5/BUILD b/perl-cpan/digest-md5/BUILD
> deleted file mode 100755
> index e79fe43..0000000
> --- a/perl-cpan/digest-md5/BUILD
> +++ /dev/null
> @@ -1 +0,0 @@
> -source $SECTION_DIRECTORY/PERL_BUILD
> diff --git a/perl-cpan/digest-md5/DETAILS b/perl-cpan/digest-md5/DETAILS
> index 95b6f20..faff73d 100755
> --- a/perl-cpan/digest-md5/DETAILS
> +++ b/perl-cpan/digest-md5/DETAILS
> @@ -5,9 +5,8 @@ SOURCE_DIRECTORY=$BUILD_DIRECTORY/Digest-MD5-$VERSION
> SOURCE_URL[0]=http://www.cpan.org/authors/id/G/GA/GAAS/$SOURCE
>
> SOURCE_HASH=sha512:00362fe462813f30257ea74e58dd2e75857e4c4ab78227c2ccc49c07
>c7692032dbe32f9f6f83565ec88bc42a94527c6b50d603c206261f1edef23f196aa73be9
> LICENSE=ART
> - WEB_SITE="http://search.cpan.org/search?module=Digest::MD5"
> + WEB_SITE=http://search.cpan.org/~gaas/Digest-MD5/
> ENTERED=20020312
> - UPDATED=20050329
> KEYWORDS="perl"
> SHORT="MD5 message digest algorithm"
> cat << EOF
> diff --git a/perl-cpan/digest-md5/HISTORY b/perl-cpan/digest-md5/HISTORY
> index d35db70..5d2c16f 100644
> --- a/perl-cpan/digest-md5/HISTORY
> +++ b/perl-cpan/digest-md5/HISTORY
> @@ -1,3 +1,7 @@
> +2008-01-07 Vlad Glagolev <stealth AT sourcemage.org>
> + * DETAILS: cleaned up, removed UPDATED
> + * BUILD: useless
You removed UPDATED, but there is no other "queueing" change - you can do
this
only when changing the version or the patchlevels, otherwise some
hipotethical user with a really old grimoire wouldn't get the spell in
queue,
while he should.
The same applies to:
lingua-ispell
mime-base64
uri
> diff --git a/perl-cpan/gtk/BUILD b/perl-cpan/gtk/BUILD
> index f405ed2..cc5eabe 100755
> --- a/perl-cpan/gtk/BUILD
> +++ b/perl-cpan/gtk/BUILD
> @@ -1,5 +1,2 @@
> -patch -p1 < $SCRIPT_DIRECTORY/Makefile.diff &&
> -make_single &&
> -perl Makefile.PL &&
> -make &&
> -make_normal
> +patch -p1 < $SCRIPT_DIRECTORY/Makefile.diff &&
> +default_build_perl
> diff --git a/perl-cpan/gtk/HISTORY b/perl-cpan/gtk/HISTORY
> index 4726e74..5c8e514 100644
> --- a/perl-cpan/gtk/HISTORY
> +++ b/perl-cpan/gtk/HISTORY
> @@ -1,3 +1,6 @@
> +2008-01-07 Vlad Glagolev <stealth AT sourcemage.org>
> + * BUILD: cleaned up
> +
> 2006-09-21 Juuso Alasuutari <iuso AT sourcemage.org>
> * DETAILS: [automated] Removed BUILD_API=2.
>
Are the make_single and make_normal really not needed? You didn't document
this change either, but they were added for a reason.
The same applies to:
mail-clamav
mp3-tag
xml-sax-expat
xml-sax
> diff --git a/perl-cpan/libnet-perl/BUILD b/perl-cpan/libnet-perl/BUILD
> index 0cdd26e..73f6094 100755
> --- a/perl-cpan/libnet-perl/BUILD
> +++ b/perl-cpan/libnet-perl/BUILD
> @@ -1 +1,2 @@
> -PERL_MM_USE_DEFAULT=1 . "$SECTION_DIRECTORY/PERL_BUILD"
> +export PERL_MM_USE_DEFAULT=1 &&
> +default_build_perl
> diff --git a/perl-cpan/libnet-perl/HISTORY b/perl-cpan/libnet-perl/HISTORY
> index 76e8d28..056ae7f 100644
> --- a/perl-cpan/libnet-perl/HISTORY
> +++ b/perl-cpan/libnet-perl/HISTORY
> @@ -1,3 +1,6 @@
> +2008-01-07 Vlad Glagolev <stealth AT sourcemage.org>
> + * BUILD: cleaned up
> +
> 2007-03-19 Elisamuel Resto <ryuji AT mages.ath.cx>
> * DETAILS: version bump to 1.20 from 1.19
>
Is the export really needed (I doubt it)? We don't like export at all, as it
could mess up more than the current environment.
The same applies to:
net-dns
pgsql_perl5
xml-sax-expat
xml-sax