To: SM-Commit Daemon <sm-commit AT lists.ibiblio.org>
Cc: duane_malcolm <d.malcolm AT auckland.ac.nz>, Unet <unet AT sourcemage.org>, Andrew Stitt <a AT t.armory.com>, Arjan Bouter <abouter AT sourcemage.org>, Treeve Jelbert <treeve01 AT pi.be>, vladimir_marek <vlmarek AT volny.cz>, Maurizio Boriani <baux AT member.fsf.org>, Ethan Grammatikidis <eekee AT eekee.is-a-geek.org>, Gareth Clay <gareth AT caffeinefuelled.co.uk>
Subject: Re: [SM-Commit] PERFORCE change 79717 by Treeve Jelbert for review
Date: Tue, 23 May 2006 20:10:21 +0200
On Tue, May 23, 2006 at 08:02:43PM +0200, Arwed von Merkatz wrote:
> On Tue, May 23, 2006 at 07:00:02PM +0100, Perforce Review Daemon wrote:
> > Change 79717 by treeve_jelbert@treeve-knowhow on 2006/05/23 18:58:45
> >
> > wxgtk - apply patches
>
> What are these? The url definitely doesn't look official, why are they
> needed?
Also, that's an invalid use of PATCHLEVEL. PATCHLEVEL is a SPELL
variable, not some arbitrary value. If we now change the spell in a
significant way, incrementing PATCHLEVEL will break this SOURCE2, that's
not acceptable.