Cc: duane_malcolm <d.malcolm AT auckland.ac.nz>, Unet <unet AT sourcemage.org>, Andrew Stitt <a AT thefrayedknot.armory.com>, SM-Commit Daemon <sm-commit AT lists.ibiblio.org>, Ladislav Hagara <ladislav.hagara AT unob.cz>, Arjan Bouter <abouter AT sourcemage.org>, vladimir_marek <vlmarek AT volny.cz>, Maurizio Boriani <baux AT member.fsf.org>, Ethan Grammatikidis <eekee AT eekee.is-a-geek.org>, Gareth Clay <gareth AT caffeinefuelled.co.uk>
Subject: Re: [SM-Commit] PERFORCE change 78382 by Flavien Bridault for review
Date: Tue, 25 Apr 2006 15:27:47 -0700
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Perforce Review Daemon wrote:
> Change 78382 by flavien_bridault@flavien-Gargamel on 2006/04/25 15:31:50
>
> solved bug #11472 - Note that I made some stuff to choose between
> libxml2 and expat for XML support,
> because there are no PROVIDER for that. Did I do right ?
<snip>
It looks like you did it correctly (the main issue would be to use
config_query_list, which you did ;)).
In BUILD you have:
if [ $XML_SUPPORT = 'n' ]; then
OPTS="$OPTS --without-libxml2 --without-expat"
fi &&
It should be:
if [ $XML_SUPPORT = 'n' ]; then
OPTS="--without-libxml2 --without-expat $OPTS"
fi &&
So that user-specified options (e.g. via CONFIG_LOC) supercede our options.