[SM-Discuss] [SM-Commit] GIT changes to master games grimoire by Thomas Orgis (b5dfe26a41e44da40eb1ea1a782ab1729ddaaf7b)

Eric Sandall eric at sandall.us
Thu Sep 20 20:01:41 EDT 2007


Quoting Thomas Orgis <scm at sourcemage.org>:

> GIT changes to master games grimoire by Thomas Orgis   
> <orgis at adams.agnld.uni-potsdam.de>:
>
>  games-emulators/dosbox/BUILD |    2 ++
>  1 files changed, 2 insertions(+)
>
> New commits:
> commit b5dfe26a41e44da40eb1ea1a782ab1729ddaaf7b
> Author: Thomas Orgis <orgis at adams.agnld.uni-potsdam.de>
> Commit: Thomas Orgis <orgis at adams.agnld.uni-potsdam.de>
>
>     The missing BUILD file implied with the last commit.

I'm not sure how others feel about commits like this (and I know I've  
done these as well), but I would prefer if the erroneous commit were  
reverted and then committed as a new whole. This is to have the commit  
a whole commit and reduce the amount of "integrate commits XXX and YYY  
to get a fix for Bug #123".

And yes, I know games doesn't really do integrations except within  
itself, but the "policy" should be the same for all grimoires as it's  
the Right Way(TM) (IMO).

-- 
Eric Sandall                     |  Source Mage GNU/Linux Developer
eric at sandall.us PGP: 0xA8EFDD61  |  http://www.sourcemage.org/
http://eric.sandall.us/          |  http://counter.li.org/  #196285

----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.




More information about the SM-Discuss mailing list