[SM-Commit] GIT changes to master grimoire by Remko van der Vossen (290b1ae0bdbe62e5cf9a79687f3bbf9c72987c3f)

Eric Sandall eric at sandall.us
Wed Aug 18 15:43:25 EDT 2010


On Aug 18, 2010, at 11:51 AM, Remko van der Vossen wrote:

> GIT changes to master grimoire by Remko van der Vossen <wich at sourcemage.org>:
> 
> graphics/zgv/HISTORY   |    4 ++++
> graphics/zgv/PRE_BUILD |    4 ++++
> 2 files changed, 8 insertions(+)
> 
> New commits:
> commit 290b1ae0bdbe62e5cf9a79687f3bbf9c72987c3f
> Author: Remko van der Vossen <wich at sourcemage.org>
> Commit: Remko van der Vossen <wich at sourcemage.org>
> 
>    zgv: fixed build for new gcc
> 
> diff --git a/graphics/zgv/HISTORY b/graphics/zgv/HISTORY
> index f747093..84f5246 100644
> --- a/graphics/zgv/HISTORY
> +++ b/graphics/zgv/HISTORY
> @@ -1,3 +1,7 @@
> +2010-08-18 Remko van der Vossen <wich at sourcemage.org>
> +	* PRE_BUILD: sed to allow compilation with newer gcc
> +	             sed to install man pages in /usr/share


Just some nitpicks:
* These should be two separate commits (as we might want the man page fix into stable, but not need the GCC fix)
* Which "newer" GCC is this for? 4.4 in test or 4.5 in devel-gcc?
* Should have a PATCHLEVEL++ for new man page location

-sandalle

Eric Sandall                     |  Source Mage GNU/Linux Developer
eric at sandall.us PGP: 0xA8EFDD61  |  http://www.sourcemage.org/
http://eric.sandall.us/          |  http://counter.li.org/  #196285
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ibiblio.org/pipermail/sm-commit/attachments/20100818/3f323c1e/attachment.html 


More information about the SM-Commit mailing list