[SM-Commit] GIT changes to master grimoire by Bor Kraljič (d7a8fe66abf6bd38d69d19707580fcbf6d849e45)

Remko van der Vossen wich at yuugen.jp
Thu Oct 1 05:05:33 EDT 2009


On Thu, Oct 01, 2009 at 10:33:13AM +0200, Bor Kraljic wrote:
> Dne četrtek 01 oktobra 2009 ob 01:52:26 je Eric Sandall napisal(a):
> > I was pretty sure kde4.sh setup the QT4 variables, since qt.sh does
> > not.  Regardless, you are correct in that it wouldn't work for
> > Sorcery anyways. :)
> > 
> > I apparently was thinking of $GRIMOIRE/kde4/FUNCTIONS and that it
> > overrides default_build for QT4 apps. $GRIMOIRE/FUNCTIONS also has a
> > qt4_cmake_build and qt4_build to take care of this for you, we
> > should use these instead.
> > 
> > -sandalle
>
> This is no cmake build so the qt4_cmake_build is out. qt4_build uses
> qmake and build of liblastfm doesn't use qmake. Also to we can't use
> default_build since the configure is a little special. (it uses space
> instead of "=" ). I was looking at the $GRIMOIRE/FUNCTIONS quite some
> time but didn't find any suitable function. 

Because these are quite subtle but very important issues perhaps it is
wise to indicate them in a comment in the BUILD script. That way someone
won't inadvertantly break the build.

Remko.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : http://lists.ibiblio.org/pipermail/sm-commit/attachments/20091001/8f39a527/attachment.bin 


More information about the SM-Commit mailing list