[SM-Commit] GIT changes to master grimoire by Treeve Jelbert (9034e037296a7633f78543836b7e409db5cf61c2)

Jaka Kranjc lynx at mages.ath.cx
Fri Jan 11 15:18:46 EST 2008


First, thanks for bringing us KDE4 this quickly! :)

On Friday 11 of January 2008 21:09:38 Treeve Jelbert wrote:
>    TOOLS) [[ $QT_TOOLS == "-make" ]] && return 0;;
> +  QT3)   [[ $QT_QT3 == "-no-qt3support" ]] && return 0;;
Shouldn't this check if it is equal to -qt3support? PRE_SUB_DEPENDS should 
return 0 if the subdependency is met. You later request something that would 
fail this check.

> diff --git a/x11-toolkits/qt4/SUB_DEPENDS b/x11-toolkits/qt4/SUB_DEPENDS
> index 99404b6..fee3daa 100755
> --- a/x11-toolkits/qt4/SUB_DEPENDS
>       ;;
> +QT3)   if [[  $QT_QT3 == "-no-qt3support" ]];then
> +	echo "Qt3 support requested, forcing rebuild."  &&
> +        QT_QT3="-qt3support"
> +     ;;
>  *) echo unknown sub-depends!!! ; return 1 ;;
>  esac



-- 
We cannot command nature except by obeying her.  --Sir Francis Bacon
Have a sourcerous day! www.sourcemage.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 315 bytes
Desc: This is a digitally signed message part.
Url : http://lists.ibiblio.org/pipermail/sm-commit/attachments/20080111/15fd3b3f/attachment.bin 


More information about the SM-Commit mailing list