[SM-Commit] GIT changes to master grimoire by Treeve Jelbert (7e799545e2367f8dbf46db5c458036e5a1a2ce40)
eric at sandall.us
Wed Nov 7 12:20:28 EST 2007
On Wed, 7 Nov 2007 14:16:06 +0000
Jaka Kranjc <lynx at mages.ath.cx> wrote:
> On Wednesday 07 of November 2007 13:08:50 Treeve Jelbert wrote:
> > --- a/kde4/KDE_DEPENDS
> > +++ b/kde4/KDE_DEPENDS
> > @@ -37,7 +37,8 @@ case $SPELL in
> > ;;
> > kdebase-workspace4)
> > - depends kdelibs4 &&
> > + sub_depends qt4 OPENGL &&
> > + depends kdebase4-runtime &&
> > depends X11-SERVER
> > ;;
> Are you sure kdelibs4 isn't needed for this? Looks suspicious to me.
> Also now the added subdependency is potentially dangerous. From the
> docs: "IMPORTANT: never call sub_depends without first explicitly
> depending on the providing spell."
You should use 'depends qt4 -sub OPENGL' to do both the required
dependency and the sub-dependency.
More information about the SM-Commit