[SM-Commit] PERFORCE change 79717 by Treeve Jelbert for review

Arwed von Merkatz v.merkatz at gmx.net
Tue May 23 14:10:21 EDT 2006


On Tue, May 23, 2006 at 08:02:43PM +0200, Arwed von Merkatz wrote:
> On Tue, May 23, 2006 at 07:00:02PM +0100, Perforce Review Daemon wrote:
> > Change 79717 by treeve_jelbert at treeve-knowhow on 2006/05/23 18:58:45
> > 
> > 	wxgtk - apply patches
> 
> What are these? The url definitely doesn't look official, why are they
> needed?

Also, that's an invalid use of PATCHLEVEL. PATCHLEVEL is a SPELL
variable, not some arbitrary value. If we now change the spell in a
significant way, incrementing PATCHLEVEL will break this SOURCE2, that's
not acceptable.

> > Affected files ...
> > 
> > ... //sgl/grimoires/devel/x11-toolkits/wxgtk/DETAILS#12 edit
> > ... //sgl/grimoires/devel/x11-toolkits/wxgtk/HISTORY#24 edit
> > ... //sgl/grimoires/devel/x11-toolkits/wxgtk/PRE_BUILD#4 add
> > 
> > Differences ...
> > 
> > ==== //sgl/grimoires/devel/x11-toolkits/wxgtk/DETAILS#12 (xtext) ====
> > 
> > @@ -6,10 +6,14 @@
> >            SOURCE=$SPELLX-$VERSION.tar.bz2
> >  SOURCE_DIRECTORY=$BUILD_DIRECTORY/$SPELLX-${VERSION//-rc1}
> >     SOURCE_URL[0]=$SOURCEFORGE_URL/wxwindows/$SOURCE
> > +# patches
> > +    PATCHLEVEL=2
> > +   SOURCE2_HASH=sha512:c79dd25cbc522818aa93dcd24f156d151349a3408f53194ac3d03de480bf97c55c014629e73ae5b0c9743bf2a97bfed0b0c379ee6ec25e7dca00e1492c963df8
> > +          SOURCE2=$SPELLX-$VERSION-Patch-$PATCHLEVEL.tar.gz
> > +   SOURCE2_URL[0]=ftp://biolpc22.york.ac.uk/pub/$VERSION/$SOURCE2
> >        LICENSE[0]=http://www.wxwidgets.org/licence3.txt
> >          WEB_SITE=http://www.wxwidgets.org/
> >           ENTERED=20011217
> > -         UPDATED=20050707
> >             TMPFS=off
> >          KEYWORDS="x11 libs"
> >             SHORT='GTK+ verion of wxWidgets API'
> > 
> > ==== //sgl/grimoires/devel/x11-toolkits/wxgtk/HISTORY#24 (text) ====
> > 
> > @@ -1,3 +1,8 @@
> > +2006-05-23 Treeve Jelbert <treeve01 at pi.be>
> > +	* DETAILS: add patch file
> > +	  set PATCHLEVEL
> > +	* PRE_BUILD: add, apply patch
> > +
> >  2006-03=25 Treeve Jelbert <treeve01 at pi.be>
> >  	* DETAILS: version 2.6.3
> >  
> > _______________________________________________
> > SM-Commit mailing list
> > SM-Commit at lists.ibiblio.org
> > http://lists.ibiblio.org/mailman/listinfo/sm-commit
> > 
> 
> -- 
> Arwed v. Merkatz                              Source Mage GNU/Linux developer
>                                                     http://www.sourcemage.org
> _______________________________________________
> SM-Commit mailing list
> SM-Commit at lists.ibiblio.org
> http://lists.ibiblio.org/mailman/listinfo/sm-commit
> 

-- 
Arwed v. Merkatz                              Source Mage GNU/Linux developer
                                                    http://www.sourcemage.org



More information about the SM-Commit mailing list