[SM-Commit] PERFORCE change 78956 by Robin Cook for review
seth at swoolley.homeip.net
seth at swoolley.homeip.net
Sun May 7 12:55:34 EDT 2006
On Sun, May 07, 2006 at 10:40:26AM +0200, Andra?? ruskie Levstik wrote:
> Perforce Review Daemon wrote :
>
> > ==== //sgl/grimoires/test/x11-toolkits/xaw3d/BUILD#2 (xtext) ====
> >
> > @@ -9,4 +9,9 @@
> > sedit 's/#define wcsncpy.*$//' XawI18n.h &&
> > xmkmf &&
> > make Makefiles &&
> > +
> > +if spell_ok xorg-server; then
> > + sedit "s:/X11R6::g" Makefile
> > +fi &&
> > +
> > make
> >
>
> IMHO this would be better if it would be done like this:
> if test "$(get_spell_provider $SPELL X11-LIBS)" = xorg-server; then
> sedit "s:/X11R6::g" Makefile
> fi &&
Technically one should check to see what they selected for the X11-LIBS
provider for this spell, but I don't know an api-correct way to do that.
Grepping the depends file should work though.
Seth
More information about the SM-Commit
mailing list