[freetds] git push #1
freddy77 at gmail.com
Sat May 19 08:57:28 EDT 2012
2012/5/18 James K. Lowden <jklowden at freetds.org>:
> For anyone interested in the git repository, I just pushed my first
> commit with
> git push ssh://firstname.lastname@example.org/freetds/freetds.git
> It seemed work. I'm still getting the hang of git.
Yes, confirmed !!
I think that "git push" is enough.
> There are two changes:
> 1. fix code that induces warnings in clang. All innocuous.
> 2. remove txt2man.
> All man pages are now in -mdoc format. It was a few hours' work. The
> man pages now look a little better and we lose one dependency. With a
> little cleverness, we could have them in PDF format, too.
> The warnings were mostly about using // as a comment, something I'm
> guilty of. These became either /**/ or #if 0.
> The most significant changes are to md4.c and md5.c. Each had a line
> memset(ctx, 0, sizeof(ctx));
> memset(ctx, 0, sizeof(*ctx));
> The line intends to clear memory before returning to prevent sensitive
> data from remaining in memory. It was clearing sizeof(void*) instead of
> the whole structure.
I backported the change of memset as a small security issue. Well spot!
I noted that you fixed the +1 version issue too. Good!
However I found a small issues, 0_91.46 should be 0.91.46.
Spec file is updated too. Good!
More information about the FreeTDS