[freetds] [PATCH] useless CHECK_NULP in dblib.c:tdsdbopen()

Craig A. Berry craigberry at mac.com
Fri Mar 20 13:52:35 EDT 2009


The CHECK_NULP statement removed by the attached patch is not actually  
checking anything except whether random data from the stack is non- 
zero.  Usually it will be, but why depend on it and what good would it  
do to know that?

My compiler said something about "dbproc fetched but not initialized"  
and I'm sure gcc and other compilers have ways to generate similar  
warnings.
________________________________________
Craig A. Berry
mailto:craigberry at mac.com

"... getting out of a sonnet is much more
  difficult than getting in."
                  Brad Leithauser

-------------- next part --------------
A non-text attachment was scrubbed...
Name: nulp.patch
Type: application/octet-stream
Size: 421 bytes
Desc: not available
Url : http://lists.ibiblio.org/pipermail/freetds/attachments/20090320/f9f9f883/attachment.obj 
-------------- next part --------------




More information about the FreeTDS mailing list