[freetds] [ freetds-Patches-1868995 ] data conv. errors on SQLFetchScroll don't create error recs

SourceForge.net noreply at sourceforge.net
Fri Feb 8 04:40:46 EST 2008


Patches item #1868995, was opened at 2008-01-11 02:22
Message generated for change (Settings changed) made by freddy77
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=407808&aid=1868995&group_id=33106

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: odbc
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: billmon (billmon)
Assigned to: Nobody/Anonymous (nobody)
Summary: data conv. errors on SQLFetchScroll don't create error recs

Initial Comment:
If you try to perform an invalid data conversion on an array bound SQLFetchScroll operation (although I believe the bug occurs on a single row SQLFetch as well), like taking a TDS datetime data  field returning from a query and trying to write it into a SQL_DOUBLE program bind location, the call to convert_tds2sql in _SQLFetch properly detects the conversion error and  _SQLFetch and SQLFetchScroll properly return SQL_ERROR but a subsequent call to SQLGetDiagRec returns SQL_NO_DATA.  That's because the code that detects the conversion error fails to add a diagnostic error message to stmt->errs.  The result is that a user will have no information from which to diagnose the problem.  See attached patch file.

----------------------------------------------------------------------

>Comment By: Frediano Ziglio (freddy77)
Date: 2008-02-08 10:40

Message:
Logged In: YES 
user_id=75766
Originator: NO

Yes, errors from tds_convert was not fully handled. Fixed in 0.82 and CVS
HEAD. I reported your interesting comment as a TODO comment in CVS HEAD. 

Thanks
  Frediano Ziglio


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=407808&aid=1868995&group_id=33106


More information about the FreeTDS mailing list