[freetds] Big patch...

James K. Lowden jklowden at freetds.org
Mon Jul 2 08:08:18 EDT 2007


ZIGLIO, Frediano, VF-IT wrote:
> 
> If nobody complaints I'll merge this work in a couple of days...

Hi Freddy, 

I have a few concerns about this patch.  

First, things are pretty stable and I'm thinking of making a release.  I'd
rather not make such fundamental changes at this point.  Could we agree on
a release schedule and postpone until we branch?  

Second, I know you love DSTR but I don't.  I think they're harder to debug
than ordinary char*.  I'm not that happy with using them in the TDS layer.
 

Third, I don't think we should change column_name to column_label
everywhere just because there are a few odd cases where the protocol
distinguishes.  Most of the time the label *is* the name for all intents
and purposes.  And, everyone knows what a column name is: it's the name of
the column.  Calling it a  "label" is nonstandard and somewhat confusing. 


I think it would be better to retain column_name for normal use, and have
a different name, say, underlying_name or table_column_name  to denote the
name of the table's column.   (Honestly, I doubt the value of knowing the
information in the first place....)

Kind regards, 

--jkl


More information about the FreeTDS mailing list