[freetds] Change in config.c
ZIGLIO, Frediano, VF-IT
Frediano.Ziglio at vodafone.com
Thu Mar 2 11:21:08 EST 2006
I saw some changes in config.c. Mainly I saw the warning compiling
(http://freetds.sourceforge.net/out/test/make.html). Is it intentional
to remove tds_config_env_tdshost call from tds_fix_connection?
I like the idea of a single #if !defined(WIN32... whoever implementing
using a struct of char* instead of #define or static const char name[] =
... lead some "issues":
- I don't think gcc (or other compiler) is so clever to detect possible
formatting errors calling tdsdump_log
- in static const { char * xxx } xxx is a char * const, perhaps it would
be better a const char * const
- I don't like the extra space used to store pointers... someone could
spot that 20/40 bytes (5 pointers in 32/64 bit) are very few but
considering possible relocation these 5 pointers waste some hundred
bytes.
freddy77
More information about the FreeTDS
mailing list