[freetds] [PATCH bcp.c:_bcp_read_hostfile] don't trim trailing spaces when all spaces

Craig A. Berry craigberry at mac.com
Tue Dec 20 09:07:04 EST 2005


At 9:49 AM +0100 12/20/05, ZIGLIO, Frediano, VF-IT wrote:
> >
>> > From: Craig A. Berry
>> > Sent: Sunday, December 18, 2005 11:38 PM
>> >
>> > When bulking in character data, we currently trim trailing spaces,
>> > which in general seems like the right thing to do with one
>> exception.
>> > The exception is when a field is all spaces; I don't think we should
>> > trim those to nothing because then we end up inserting nulls in
> > > what may or may not be nullable fields.


>well, current rtrim implementation should handle correctly this case.

Good catch.  I noticed the problem with 0.63 and submitted the patch
against the current snapshot without noticing that it's no longer
necessary.  Ignore this one.
-- 
________________________________________
Craig A. Berry
mailto:craigberry at mac.com

"... getting out of a sonnet is much more
 difficult than getting in."
                 Brad Leithauser


More information about the FreeTDS mailing list