[freetds] Nightly build fails

Frediano Ziglio freddyz77 at tin.it
Sun Apr 3 05:07:13 EDT 2005


... 
> > - comment out num_limits.h rule if perl is not detected in configure
> > (still used for documentation in root Makefile.am)
> 
> Your last option leads to another that is much better IMHO: let configure
> determine if numeric.pl exists.  For CVS, yes, for distribution, no. 
> src/tds/Makefile.am then gets something like:
> 
> 	if HAVE_NUMERIC_DOT_PL
> 	num_limits.h: numeric.pl Makefile
> 		perl $(srcdir)/numeric.pl > .$@ 
> 		mv .$@ $@
> 	endif
> 
> I don't have time to play with that right now, but I'll look at it later. 
> Thanks for your thoughts, Freddy.  You helped clarify the situtation for
> me.  
> 

I saw result on CVS. Very clean!!!

As an improvement I would rearrange all autogenerated perl code:
1- convert.c contains an embedded perl script to generate
tds_willconvert.h
2- sybase_character_sets.h.pl take sybase_character_sets.h and
alternative_character_sets.h to generated updated
sybase_character_sets.h
3- encoding.pl take character_sets.h, alternative_character_sets.h and
sybase_character_sets.h to generate encoding.h (used by iconv.c)
4- numeric.pl produce num_limits.h
I would rearrange in such way
1- separate in a different file (say tds_willconvert.pl)
2 and 3- put in a single perl script (encoding.pl and produce
encoding.h)
4- perhaps a name like num_limits.pl can help
(or use a name like xxxxx.h.pl for all above script??)
Perhaps is also a good idea to rename (or incorporate in perl script)
all false include file (sybase_character_sets.h, character_sets.h,
alternative_character_sets.h)

freddy77




More information about the FreeTDS mailing list