[freetds] Data conversion limit for strings

ZIGLIO, Frediano, VF-IT Frediano.Ziglio at vodafone.com
Mon Jan 26 07:50:24 EST 2004


> 
> Hi James and Freddy,
> 
> > Thanks for finding our bug.  Please try the attached patch. 
>  If it works,
> > I'll apply it to the 0.62 branch.  At the very least, it 
> will make your
> > log bigger.  
> 
> Yep, it worked. Fantastic, thanks for your help. I made some 
> more test with a very large amount of Japanese and Chinese 
> signs, and they were transmitted to the database totally correct.
> 
> Below you will find the log for the working insert, to see 
> what the new log
> entries print out.
> 
> Again, thanks for your help. If I can support your project in 
> any way, let me know.
> 
> Best regards,
> 
> Marco Brinkmann
> 

Thanks. Could you please send more log (like packet sent) ?

Patch works however it's the correct way to fix problem? We ignore all
errors replacing with logs... Perhaps it should be better to return 0
from tds_iconv on EINVAL and suppress->einval ?? Or just continue (in
write.c) if we get EINVAL and there is still data to write (len > 0) ??
IMHO this patch should be put on 0.62 too...

utf_2 test do not detect error cause it tests output while utf_1 do not
detect cause it use small buffers...

freddy77



More information about the FreeTDS mailing list