[ freetds-Patches-596008 ] trusted tds7 login

Frediano Ziglio freddyz77 at tin.it
Fri May 2 19:13:14 EDT 2003


Il ven, 2002-08-16 alle 17:19, Brian Bruns ha scritto:
> Freddy,
> 
> This looks awesome!  How much testing have you done with it and in what
> kind of environments?
> 
> Brian
> 

I have tested with a server on my firm
- tested 2 login (a test login and personal one)
- NT domain (not w2k)
- one server (sql 7, with tds7)

Applying this patch work either with normal login and domain login (not
together... I not test this, nor I know if this is possible).

I note also in src/tds/Makefile.am this line:
   LIBS            = @LIBICONV@
doing so do not include libraries added in configure stuff.
Also we should add challenge.lo to libraries makefiles...
Perhaps @LIBICONV@ should be added to lib_LTLIBRARIES...

I'm not very happy for this patch (as you note I have lowered priority)
for previous reason and because I changed code using const pointer and
calling tds_put_XXX (I changed this to const but I think this patch can
wait future release).

I think before applying this patch is best to fix other things...
Should I put this on a higher priority?
I not so a long work but need some test (see also my previous mail "Some
API change")...

freddy77





More information about the FreeTDS mailing list