[ freetds-Patches-580070 ] Rewrite string_to_numeric

noreply at sourceforge.net noreply at sourceforge.net
Thu Jul 11 06:52:48 EDT 2002


Patches item #580070, was opened at 2002-07-11 05:52
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=407808&aid=580070&group_id=33106

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Rewrite string_to_numeric

Initial Comment:
This function wasn't very good.

- Source string is not always terminated.

- Had many buf overflow (copying string, converting to 

binary and other).

- Input not checked...

- Allocate a linked list just to store some digit. Use short 

int for counter (on some machine like Intel give poor 

performance)

-Do not test overflow or strange character

Perhaps this version need some testing on big-endian 

machine (it use always little endian ordering... correct?)



Also I made a test for this conversion.



freddy77



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=407808&aid=580070&group_id=33106



More information about the FreeTDS mailing list