[cc-devel] [PATCH] Re: Extracting Embedded Licenses
Jason Kivlighn
jkivlighn at gmail.com
Sun Jul 1 17:35:05 EDT 2007
>
> On Sat, 2007-06-30 at 20:19 -0700, Jason Kivlighn wrote:
>
>>> these look ok - will apply as soon as the other stuff is tidied up (need
>>> tracker_read_xmp before I can apply these)
>>>
>>>
>> Here's a patch that just adds tracker_read_xmp. It reads licenses and
>> dublin core metadata from XMP, and could easily be extended to other
>> schemas (like exif).
>>
>>
>
> its not correct because DC is abstract in tracker and must not be used
> to store metadata - you must use a subclass of the DC type instead
>
> EG
>
> for Docs
>
> Doc:Title is a subclass of DC:Title
>
> For Images
>
> Image:Title is a subclass of DC:Title
>
>
> what you will need to do is use the service type to determine which
> subclass to use
>
> For now you can just set it for Images if you like
>
Here's a patch that just uses Image:* for now and fixes the style issues
(I hope I got them all). Hopefully this can make it into 0.6, along
with the extractor updates.
Regarding using the service type, that's going to take more extensive
updates to Tracker. All extraction of XMP is done from tracker-extract,
which doesn't know the service type. Maybe extend
tracker_metadata_get_embedded(...) to somehow post-process the extracted
fields. Or maybe also pass along the service type to tracker-extract.
I'm not sure the most elegant solution here.
Cheers,
Jason
> also theres still a number of lines which omit spacing EG:
> if (strcmp(qual_path,"xml:lang") == 0) {
>
>
> I can tidy this up for you but it will probably take a few days as im
> busy getting 0.6 out of the door atm
>
> If you can fix today then I can include it in the next release
>
> jamie
>
>
>
>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: tracker-read-xmp.patch
Url: http://lists.ibiblio.org/pipermail/cc-devel/attachments/20070701/bc74853c/attachment.bat
More information about the cc-devel
mailing list